Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add No EORG popup on round end #96

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Add No EORG popup on round end #96

merged 3 commits into from
Sep 30, 2024

Conversation

FluffMe
Copy link
Collaborator

@FluffMe FluffMe commented Sep 30, 2024

About the PR

Adds a popup on round end with a reminder about no EORG rules.

  • Close button is timed -- enabled after 5 seconds.
  • "Don't show again" checkbox works via CVar.

Why / Balance

A lot of bwoinks are pure EORG from players who are new to the server and didn't read the rules.
This reminder, hopefully, will improve the situation and give admins time to do something other than EORG bwoinks.

Technical details

  • RoundEndNoEorgUIController subscribes to the Network Event RoundEndMessageEvent.
  • CLIENTONLY harmony.skip_roundend_noeorg CCVar controls if the popup will be shown or not.
    Saved to client config.
  • For testing purposes, you can set ccvar harmony.skip_roundend_noeorg false in console to see the popup again on round end, after it was dismissed with "Don't show again" checkmark.

File changes

Locale files

  • Resources/Locale/en-US/_Harmony/round-end/round-end-no-eorg-window.ftl -- All the strings.
    To avoid hardcode and allow easy modification without going into C#.

Content.Client._Harmony.RoundEnd Namespace

  • Content.Client/_Harmony/RoundEnd/RoundEndNoEorgUIController.cs -- Controller logic.
  • Content.Client/_Harmony/RoundEnd/RoundEndNoEorgWindow.cs -- Defines the window.

Content.Shared._Harmony.CCVars Namespace

New namespace for Harmony CCVars -- HCCVars.

  • Content.Shared/_Harmony/CCVars/HCCVars.cs -- Defines all HCCVars

Media

image

no_eorg-2024-09-30_15.59.35.mp4

Notes

In hindsight this would be a lot more easier and concise with XAML, but oh well...

Changelog
🆑

  • add: Added no EORG reminder popup at the end of the round.

@FluffMe FluffMe requested a review from KeldWolf September 30, 2024 14:48
@github-actions github-actions bot added the S: Needs Review Review is requested label Sep 30, 2024
Copy link

@KeldWolf KeldWolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very approved. Actual code additions to Harmoy. Wild.

@KeldWolf KeldWolf merged commit 4ccc76e into master Sep 30, 2024
11 checks passed
@FluffMe FluffMe deleted the no-eorg-popup branch September 30, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Needs Review Review is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants