Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Adds a popup on round end with a reminder about no EORG rules.
Why / Balance
A lot of bwoinks are pure EORG from players who are new to the server and didn't read the rules.
This reminder, hopefully, will improve the situation and give admins time to do something other than EORG bwoinks.
Technical details
RoundEndNoEorgUIController
subscribes to the Network EventRoundEndMessageEvent
.harmony.skip_roundend_noeorg
CCVar controls if the popup will be shown or not.Saved to client config.
ccvar harmony.skip_roundend_noeorg false
in console to see the popup again on round end, after it was dismissed with "Don't show again" checkmark.File changes
Locale files
Resources/Locale/en-US/_Harmony/round-end/round-end-no-eorg-window.ftl
-- All the strings.To avoid hardcode and allow easy modification without going into C#.
Content.Client._Harmony.RoundEnd
NamespaceContent.Client/_Harmony/RoundEnd/RoundEndNoEorgUIController.cs
-- Controller logic.Content.Client/_Harmony/RoundEnd/RoundEndNoEorgWindow.cs
-- Defines the window.Content.Shared._Harmony.CCVars
NamespaceNew namespace for Harmony CCVars -- HCCVars.
Content.Shared/_Harmony/CCVars/HCCVars.cs
-- Defines all HCCVarsMedia
no_eorg-2024-09-30_15.59.35.mp4
Notes
In hindsight this would be a lot more easier and concise with XAML, but oh well...
Changelog
🆑