-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could this gem be rails independent? #19
Comments
You're right I could have avoided it, the implementation I chose was to be plug & play in a Rails controller. It uses 2 features of ActiveSupport:
All the logic is in this file: https://github.com/ssaunier/github_webhook/blob/master/lib/github_webhook/processor.rb |
@chrismytton built something similar for Sinatra https://github.com/chrismytton/sinatra-github_webhooks. |
Thanks for the plug, @nickhammond 🙂 I also made a pure Rack solution rack-github_webhooks, which works without Sinatra or Rails. |
Thank you @nickhammond & @chrismytton! Closing this issue as there are alternative gems now 🍾 |
FYI I added those two alternatives to the |
Was hoping to make use of this really useful gem for my simple sinatra app but unfortunately it looks like it depends on Rails concerns and active support.
This doesn't seem super necessary, however, and was wondering about the possibility of making this gem capable of working without being used in a rails context?
The text was updated successfully, but these errors were encountered: