Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssb-client in the browser tries to use net: remotes #33

Open
regular opened this issue Oct 14, 2018 · 4 comments
Open

ssb-client in the browser tries to use net: remotes #33

regular opened this issue Oct 14, 2018 · 4 comments

Comments

@regular
Copy link
Contributor

regular commented Oct 14, 2018

When passing the result of sbot getAddress to ssbClient, it results in net.connect is not a function

@regular
Copy link
Contributor Author

regular commented Oct 14, 2018

To reproduce:

git clone https://github.com/regular/ssb-integration-tests.git
cd ssb-integration-tests
npm i
npm t

@stale
Copy link

stale bot commented Jan 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 9, 2019
@stale stale bot removed the stale label Jan 9, 2019
@christianbundy christianbundy self-assigned this May 28, 2019
@austinfrey
Copy link

@christianbundy @regular this is still an issue i think. i solved it by supplying a remote url in the config when passing it to the client. should the client attempt all protocols when net fails? i think net is hardcoded now when not passing in a remote.

    const sbot = await ssbClient(
      keys,
      Config('ssb', {
        remote: 'ws://localhost:8989~shs:EaYYQo5nAQRabB9nxAn5i2uiIZ665b90Qk2U/WHNVE8=.ed25519',
        caps,
      })
    )

@christianbundy christianbundy removed their assignment Jan 31, 2021
@stale
Copy link

stale bot commented Jun 2, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the stale label Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants