Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsonschema conflict with jupyterlab_server #82

Closed
tharwan opened this issue Oct 26, 2023 · 2 comments
Closed

jsonschema conflict with jupyterlab_server #82

tharwan opened this issue Oct 26, 2023 · 2 comments

Comments

@tharwan
Copy link

tharwan commented Oct 26, 2023

the current version of jupyterlab_server depends on jsonschema > 4.18 which makes it incompatible with the requirements here.

Is it possible to simply relax the requirements? Could I contribute with a PR?
@dokempf
Copy link
Member

dokempf commented Oct 26, 2023

Thanks for noticing. I remember that there the jsonschema package was very much "in flux" when I was developing this, so I pinned the old, stable version. That being said, I am very open to PRs porting it to the latest version.

@tharwan tharwan mentioned this issue Oct 26, 2023
Merged
@dokempf
Copy link
Member

dokempf commented Oct 27, 2023

Thanks @tharwan for your work. It is merged and released as v1.0.1 on PyPI, conda-forge is on its way!

@dokempf dokempf closed this as completed Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tharwan @dokempf