Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow admins to edit the german translations #211

Open
lkeegan opened this issue Dec 13, 2024 · 0 comments · May be fixed by #213
Open

Allow admins to edit the german translations #211

lkeegan opened this issue Dec 13, 2024 · 0 comments · May be fixed by #213

Comments

@lkeegan
Copy link
Member

lkeegan commented Dec 13, 2024

Right now de.json is hard coded, some technical issues to resolve, but this should ideally also be editable by the admins from the admin interface

@lkeegan lkeegan added this to the Initial production version milestone Dec 13, 2024
lkeegan added a commit that referenced this issue Dec 16, 2024
- main improvements
  - de translations can now be edited from the admin interface
  - in frontend code we now have autocomplete for translation ids
- change in use
  - i18n-svelte -> lib/tr.ts
  - `$locale` -> `tr.locale`
  - `$locales` -> `tr.locales`
  - `$_('a.b')` -> `tr.d.a.b`
  - to add a text, add the id to lib/translations.ts
- code changes
  - remove i18n-svelte library
  - remove locales/de.json: this is now included in the static folder of the deployed website, not part of the frontend source code anymore
  - use camel case for all translation ids for consistency and to allow use without quotes
  - de is now also editable in admin interface
- resolves #211

TODO: relabel? tr -> i18n, .d -> .tr, i.e. `i18n.tr.a.b`
lkeegan added a commit that referenced this issue Dec 17, 2024
- main improvements
  - all language texts can now be edited from the admin interface
  - in frontend code we now have autocomplete for translation ids
- change in use
  - i18n-svelte -> lib/i18n.svelte
  - `$locale` -> `i18n.locale`
  - `$locales` -> `i18n.locales`
  - `$_('a.b')` -> `i18n.tr.a.b`
  - to add a text, add the id to lib/translations.ts
- code changes
  - remove i18n-svelte library
  - remove locales/de.json: this is now included in the static folder of the deployed website, not part of the frontend source code anymore
  - use camel case for all translation ids for consistency and to allow use without quotes
  - de is now also editable in admin interface
- resolves #211
@lkeegan lkeegan linked a pull request Dec 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant