Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New client suggestions on the feedback page #227

Open
Majapur1 opened this issue Feb 13, 2025 · 11 comments · May be fixed by #232
Open

New client suggestions on the feedback page #227

Majapur1 opened this issue Feb 13, 2025 · 11 comments · May be fixed by #232
Assignees
Labels

Comments

@Majapur1
Copy link
Collaborator

Below is a series of client comments on the appearance of this page:

  • we need to add the title;
  • the description should be changed as in the example (volume reduction);
  • all texts (descriptions, details under the button and legend) need to match the latest version of the client (I'll attach it below);
  • the legend should stay open all the time without wrapping (we can reduce the scrolling time with a shorter description);
  • get rid of the buttons "Feedback zu vorherigen Beobachtungszeiträumen anzeigen", "Mehr Informationen zur Erstellung der Bewertung" and blue arrows around the previous periods. It can just be there all the time;
  • add the button "Mehr Info zur Bewertung" at the same level as the second title (I'll attach the new text of it below);
  • the customer's request is that the primary color (blue) be used only for milestones. The accordion headers need to be blue. For other elements on the site we can use the "additional-color" options. They are already added to tailwind.config.ts;
  • the feedback for the overall score should be presented before the Individual development areas;
  • can we have 3 or 2 columns of milestone groups on wide screens;
  • The user should only be able to see the problematic milestones under a milestones group (green ones should be invisible). The background of a problematic milestone on opening is (yellow) color #f3ddb0.
Image
@Majapur1
Copy link
Collaborator Author

Title:

Feedback zum Entwicklungsstand des Kindes

Das Feedback basiert auf einem Vergleich Ihrer Einschätzungen mit den Einschätzungen anderer Nutzer, die und folgt einer einfachen Regel:

Green traffic light symbol:

Alles im grünen Bereich

Das Kind hat für sämtliche Meilensteine altersgemäße Bewertungen erhalten.

Yellow traffic light symbol:

Aufgepasst!

Das Kind hat für einige Meilensteine leicht unterdurchschnittliche Werte erhalten.

Red traffic light symbol:

Entwicklungsverzögerung

Das Kind erreicht Werte, die deutlich unter dem Altersdurchschnitt liegen.

Button “Mehr Info zur Bewertung”:

Liegt der Mittelwerte des Kindes im Bereich von plus/minus einer Standardabweichung des Mittelwertes für gleichaltrige Kinder, ist alles im grünen Bereich.

Wir stellen für jeden Meilenstein einzeln fest, ob die konkrete Einschätzung des Kindes mehr als 2 Standardabweichungen unterhalb des Mittelwerts für gleichaltrige Kinder liegt. Ist das der Fall, springt die Ampel auf gelb und der Meilenstein wird angezeigt. Bitte machen Sie sich aber noch keine Sorgen!
Ein gelbes Ampelsignal soll Sie lediglich nur dazu anregen, auf bestimmte Kompetenzen verstärkt zu achten und das Kind darin zu stärken.

Wenn der empirische Mittelwert mehr als zwei Standardabweichungen unter dem Mittelwert für gleichaltrige Kinder liegt, springt die Ampel auf rot. Das bedeutet, dass nur 2,35% aller Kinder einen niedrigeren Wert erreicht haben als das beobachtete Kind. Es besteht ein erhöhtes Risiko für Entwicklungsverzögerung.
Sie sollten einen Experten / eine Expertin aufsuchen, um abklären zu lassen, ob Handlungsbedarf besteht.

@MaHaWo MaHaWo added this to the Initial production version milestone Feb 17, 2025
@Majapur1
Copy link
Collaborator Author

Majapur1 commented Mar 4, 2025

Due to the low probability of color blindness (especially among women, ~0.4%), Ms. Pauen sees no need to add supporting symbols to the feedback traffic lights. Can we use only colors without "?", "✓", and "X"?

Image

@MaHaWo
Copy link
Collaborator

MaHaWo commented Mar 4, 2025

@Majapur1 I would like to ask a few quick questions to clarify some things:

  • about the point "remove blue arrows around the previous periods. It can just be there all the time;"

    • What if you watch a child for a year or two? Assuming a observation interval of a week, that will create 50 to 100 feedback datapoints that we cannot all display at once.
    • Should we have only the most recent 4 or 5 then?
    • If yes, how would a user who is interested about the longer term development go back in history and find how their child has been performing a few months ago, (I'm thinking about older children here primarily from 3 years upwards)? not at all?
  • " the customer's request is that the primary color (blue) be used only for milestones. The accordion headers need to be blue. For other elements on the site we can use the "additional-color" options. They are already added to tailwind.config.ts;"

    • not sure what you mean here, they are blue already?
  • " the feedback for the overall score should be presented before the Individual development areas"

    • same here, isn't that the case already?

@Majapur1
Copy link
Collaborator Author

Majapur1 commented Mar 5, 2025

@MaHaWo I need to discuss the first point with Ms. Pauen. Maybe we should really only use the 4-5 most recent reports, and make the earlier ones available for upload in PDF report format.

• Only elements that display milestones (such as the accordion headers on this page) should be blue (primary color). For all other elements, we should use the additional color or grey.

I've shown this in the screenshot below:

Image

@MaHaWo
Copy link
Collaborator

MaHaWo commented Mar 5, 2025

right, I like the idea with the history being available in the protocol. Your screenshot looks really weird however, the one I have on the current main branch looks like this:

Image

It looks like currently hosted page on mondey.lkeegan.dev still runs on an old version of this? I haven´t checked the deployment pipeline yet, but since you have a bunch of stuff in the database already, I would like to consult with @lkeegan first before I try to mess with this, lest I break something and negate your work...

You can deploy the website locally on your own machine from the repository with docker to see always the latest version. See the DEPLOYMENT.md file in the top directory of the mondey repository for how to do this.

@MaHaWo
Copy link
Collaborator

MaHaWo commented Mar 5, 2025

let me know if you need further help

@Majapur1
Copy link
Collaborator Author

Majapur1 commented Mar 5, 2025

@MaHaWo yes, my version looks completely different. Ok, I'll try to deploy it locally.

Thanks! I'll ask you if I have any questions.

@MaHaWo MaHaWo linked a pull request Mar 5, 2025 that will close this issue
10 tasks
@MaHaWo
Copy link
Collaborator

MaHaWo commented Mar 6, 2025

on the color issue:

another thing worth noting is that the european accessibility act EAA comes into effect in June 2025 (in Germany that's been nationalized as 'Barrierefreiheitsstärkungsgesetz' ('Accessibility Strengthening Act')) which forces electronic services to comply with accessibility rules and afais is relevant for us too. Even without that, the web content accessibility guidelines clearly state "Color is not used as the only visual means of conveying information, indicating an action, prompting a response, or distinguishing a visual element. " and that's a Level A requirement, i.e., a very basic one. Whether a relevant form of disability is frequent in the population or not doesn't factor in here (and red-green blindness specifically is ~8% in men).
So, I think we need to address this issue in some way.

@MaHaWo
Copy link
Collaborator

MaHaWo commented Mar 6, 2025

Aaaannddd... something that bubbled up, now that I haven´t looked at the system for a while:

  • maintaining two statistics (mean += variance) for both he individual milestones and the milestonegroups separately creates potential inconsistencies when individual milestones are in another feedback category than the milestonegroup overall:

Image

As you can see, the milestonegroup is green, but one of the milestones is yellow, and if you don´t click on the group to expand it this doesn´t show up.

I'm not sure how to handle this or if at all:

  • did I make a mistake in the computation logic or misunderstand it? here it's stated how we understood the demand, and I went from there (I hope not, the current scheme seemed logical at the time)

  • should the milestonegroup feedback be computed from the milestone statistics? This has statistical implications...

  • should we have a more fine grained scheme that indicates this issue in the feedback page?

  • can this be thought to be an artefact of the artificial data that I'm using and it's not actually happening in the real world where the grouping and the individual milestones are highly correlated?

I think we discussed this at some point superficially but the feedback page and it's backend has changed a lot since then...

@Majapur1

@Majapur1
Copy link
Collaborator Author

Majapur1 commented Mar 6, 2025

@MaHaWo Thank you for your research and your insights regarding colorblindness. I need to discuss it with Ms. Pauen one more time. Additionally, we have an alternative idea to preserve the symbols but make slight adjustments to avoid the negative connotation of the red ‘X’:

  • Green: Tick
  • Yellow: Question mark
  • Red: Exclamation mark

All of these would be inside colored circles.

@Majapur1
Copy link
Collaborator Author

Majapur1 commented Mar 6, 2025

@MaHaWo another good point to discuss!

I’ll make an appointment with Ms. Pauen this week and then come to you with the ideas about it.

Thanks!

Aaaannddd... something that bubbled up, now that I haven´t looked at the system for a while:

  • maintaining two statistics (mean += variance) for both he individual milestones and the milestonegroups separately creates potential inconsistencies when individual milestones are in another feedback category than the milestonegroup overall:

Image

As you can see, the milestonegroup is green, but one of the milestones is yellow, and if you don´t click on the group to expand it this doesn´t show up.

I'm not sure how to handle this or if at all:

  • did I make a mistake in the computation logic or misunderstand it? here it's stated how we understood the demand, and I went from there (I hope not, the current scheme seemed logical at the time)
  • should the milestonegroup feedback be computed from the milestone statistics? This has statistical implications...
  • should we have a more fine grained scheme that indicates this issue in the feedback page?
  • can this be thought to be an artefact of the artificial data that I'm using and it's not actually happening in the real world where the grouping and the individual milestones are highly correlated?

I think we discussed this at some point superficially but the feedback page and it's backend has changed a lot since then...

@Majapur1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants