Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default configs do not use suggested new list format for "inherits_from" #425

Closed
gregtkogut opened this issue Jun 20, 2022 · 3 comments · Fixed by #427
Closed

Default configs do not use suggested new list format for "inherits_from" #425

gregtkogut opened this issue Jun 20, 2022 · 3 comments · Fixed by #427

Comments

@gregtkogut
Copy link
Collaborator

gregtkogut commented Jun 20, 2022

Should the default configs be updated to use the new list format for inherits_from?

@xydesa
Copy link
Collaborator

xydesa commented Jun 21, 2022

Yea, i think that change should be made.

@denewiler
Copy link
Collaborator

I agree we should make that change.

If the code was working properly and users tried to use a string (the old method) they should have been receiving a warning from the deprecated module.

https://github.com/sscpac/statick/blob/main/statick_tool/config.py#L148

The warning says to expect support for strings to be removed in v0.8 series. We are already into the 0.8 series. We could remove code support (and the dependency on the deprecated module) if we want to. That would be a separate issue/PR.

@gregtkogut
Copy link
Collaborator Author

I haven't been seeing that warning as far as I can remember, but haven't been looking...I'll update every deprecated instance of the keyword in all the repos, and on the side test to see if that deprecation warning is being displayed.

@denewiler denewiler linked a pull request Jul 26, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants