Merging fix from @clivetong into our own SSH.NET fork

patrick-yates-redgate · patrick-yates-redgate · commit a5300908b93b · 2023-09-28T10:43:01.000+01:00
- The following article describes some of the issues with the double check lock that we have seen issues with: https://www.sudhanshutheone.com/posts/double-check-lock-csharp
diff --git a/src/Renci.SshNet/Channels/Channel.cs b/src/Renci.SshNet/Channels/Channel.cs
@@ -834,7 +834,6 @@ protected virtual void Dispose(bool disposing)
                 var session = _session;
                 if (session != null)
                 {
-                    _session = null;
                     session.ChannelWindowAdjustReceived -= OnChannelWindowAdjust;
                     session.ChannelDataReceived -= OnChannelData;
                     session.ChannelExtendedDataReceived -= OnChannelExtendedData;

Original file line number	Diff line number	Diff line change
`@@ -834,7 +834,6 @@ protected virtual void Dispose(bool disposing)`
`834`	`834`	`var session = _session;`
`835`	`835`	`if (session != null)`
`836`	`836`	`{`
`837`		`- _session = null;`
`838`	`837`	`session.ChannelWindowAdjustReceived -= OnChannelWindowAdjust;`
`839`	`838`	`session.ChannelDataReceived -= OnChannelData;`
`840`	`839`	`session.ChannelExtendedDataReceived -= OnChannelExtendedData;`