Skip to content

Terminal window resizing #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcoder76 opened this issue Jul 11, 2016 · 7 comments · Fixed by #1646
Closed

Terminal window resizing #40

jcoder76 opened this issue Jul 11, 2016 · 7 comments · Fixed by #1646

Comments

@jcoder76
Copy link

Maybe I am looking at things improperly, but I was trying to find a way to support dynamic terminal resizing using SSH.NET as the connection. Naturally the remote endpoint is expecting a window size in order to properly form the console output wrapping, but all the window sizing code in SSH.NET seems to be hidden as internals.

Although you can set the initial size in ShellStream or Shell, there are no methods for changing that while a connection is alive and you can't seem to relinquish the ShellStream and create a new one in the same connection without crashing the whole application.

I am using 2013.4.7 stable.

@jcoder76
Copy link
Author

No one is assigned to this issue, I haven't received any responses in 6 months, and no changes to this situation seem to have been implemented for 2016.0.0 which is the most current version as of the writing of this update.

To clarify this further, the component which has this feature is the ChannelSession in its SendWindowChangeRequest method. The type and its implemented interface are both marked internal, yet that method isn't used anywhere internally which indicates the absolute uselessness of this method being internal. Please expose this method somehow.

@jcoder76
Copy link
Author

Something like this is all that is needed:
Bugalex@f179b20

@jcoder76
Copy link
Author

@drieseng or @olegkap is anyone maintaining this code anymore?

It has been 9 months without any answers.

@darkoperator
Copy link

a new Beta was actually release yesterday, with tons of changes just need to take a look at the commits and issue updates. I believe it is not supported at the moment, you could do a PR based on that code and add some tests with permission of the person that did the fork.

@jerix8055
Copy link

@drieseng is there any attempt to address this issue in future releases like the 2020 beta?

@osagga
Copy link

osagga commented May 13, 2020

@drieseng any update on this? I can work on the PR, but would this feature be interesting to add? or is there an opinion on this?

@IgorMilavec
Copy link
Collaborator

I have created a discussion #926 for all ShellStream related issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants