Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual Studio OpenMP 2.0 Support #12

Open
CeruleanSky opened this issue Jan 25, 2019 · 1 comment · May be fixed by #32
Open

Visual Studio OpenMP 2.0 Support #12

CeruleanSky opened this issue Jan 25, 2019 · 1 comment · May be fixed by #32

Comments

@CeruleanSky
Copy link

CeruleanSky commented Jan 25, 2019 •
edited
Loading

If you want to support Visual Studio's OpenMP which is compiler flag"/openmp" , it has been at version OpenMP 2.0 for around a decade, and complains about size_t for the index and the error says it needs to be a signed int.

tinyraytracer/tinyraytracer.cpp

Lines 123 to 124 in 5888c49

for (size_t j = 0; j<height; j++) { // actual rendering loop
for (size_t i = 0; i<width; i++) {

So the above size_t index works when it changed to a signed int for VS compilers.

I didn't want to make a pull since I'm not quite sure what the best way to add "/openmp" to how you have your CMakeLists.txt arranged for Visual Studio.
@ssloy
Copy link
Owner

ssloy commented Jan 25, 2019

Thank you for pointing the stuff; I am not sure either how to add /openmp, let us keep the issue open for a little while.

@ssloy ssloy pinned this issue Jan 25, 2019
@scivision scivision linked a pull request Feb 22, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

avoid CMake warnings, simplify CMake script scivision/tinyraytracer
2 participants
@ssloy @CeruleanSky