Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: genesis options correct use #1749

Closed
wants to merge 14 commits into from

Conversation

olegshmuelov
Copy link
Contributor

@olegshmuelov olegshmuelov commented Sep 19, 2024

different way to fix #1747
close #1748

Base automatically changed from fix/fee-recipient-updates to stage-rc September 20, 2024 09:14
@olegshmuelov olegshmuelov changed the base branch from stage-rc to stage September 22, 2024 07:35
@olegshmuelov olegshmuelov marked this pull request as ready for review September 22, 2024 07:37
@olegshmuelov olegshmuelov self-assigned this Sep 24, 2024
Copy link
Contributor

@moshe-blox moshe-blox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@andrew-blox we should test that the fee recipient changes on both prefork and postfork with this PR

if it's already been tested, pls lmk

Copy link
Contributor

@y0sher y0sher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@moshe-blox
Copy link
Contributor

deprecated in favor of #1820

@moshe-blox moshe-blox closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve passing genesis options to SetupGenesisRunners to avoid reliance on pre-fork options
3 participants