Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define subnet type to appropriate size (uint8/uint16) #1764

Open
y0sher opened this issue Sep 29, 2024 · 0 comments
Open

Define subnet type to appropriate size (uint8/uint16) #1764

y0sher opened this issue Sep 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@y0sher
Copy link
Contributor

y0sher commented Sep 29, 2024

Description

Since we only have 126 subnets, there's no need to use large integer to identify subnets, currently uint64 is used which is an overkill. we should consider using something smaller. Even when forward thinking about a future with more subnets, there are smaller integer that will fit.

It will also be easy to define a type Subnet that will be used codebase-wide instead of using some integer, that way it'll be easier if we want to make a change in the future.

@y0sher y0sher added the enhancement New feature or request label Sep 29, 2024
@y0sher y0sher changed the title set subnet type to appropriate size (uint8) set subnet type to appropriate size (uint8/uint16) Sep 29, 2024
@y0sher y0sher changed the title set subnet type to appropriate size (uint8/uint16) Define subnet type to appropriate size (uint8/uint16) Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant