Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly implement handleOperatorRemoved #1786

Open
MatusKysel opened this issue Oct 10, 2024 · 0 comments
Open

Correctly implement handleOperatorRemoved #1786

MatusKysel opened this issue Oct 10, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@MatusKysel
Copy link
Contributor

We need to re-implement handleOperatorRemoved as it currently doing nothing

	// TODO: In original handler we didn't delete operator data, so this behavior was preserved. However we likely need to.
	// TODO: Delete operator from all the shares.
	//	var shares []Share
	//	for _, s := range nodeStorage.Shares().List() {
	//		// if operator in committee, delete him from it:
	//		//     shares = append(shares, s)
	//	}
	//	nodeStorage.Shares().Save(shares)
	// err = eh.nodeStorage.DeleteOperatorData(txn, od.ID)
	// if err != nil {
	// 	return err
	// }
@MatusKysel MatusKysel added the bug Something isn't working label Oct 10, 2024
@nkryuchkov nkryuchkov self-assigned this Oct 15, 2024
@ssvlabs ssvlabs deleted a comment Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants