Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle percentEncoded option #29

Open
1 of 3 tasks
ssssota opened this issue Dec 18, 2024 · 2 comments
Open
1 of 3 tasks

Handle percentEncoded option #29

ssssota opened this issue Dec 18, 2024 · 2 comments
Assignees
@takao-h

Comments

@ssssota
Copy link
Collaborator

ssssota commented Dec 18, 2024 •
edited by takao-h
Loading

universal-links-test/src/sim/match.ts

Line 13 in d28e970

percentEncoded: _ = true, // TODO: Handle percentEncoded

  • Research behavior
  • Write tests
  • Implement
@takao-h takao-h self-assigned this Jan 14, 2025
@takao-h
Copy link
Contributor

takao-h commented Jan 31, 2025

swcutilにおける%を含むURLの検証時の挙動の調査結果

swcutil は、URL のパスやクエリパラメータがパーセントエンコードされている場合に、それをデコードしてから一致を確認します。
例えば、/search/%2F は /search/ として扱われます。

@takao-h
Copy link
Contributor

takao-h commented Jan 31, 2025 •
edited
Loading

実装方針

  1. テストの追加
  2. デフォルト値をtrueに設定
  3. percentEncodedが含まれるときの処理を追記

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@takao-h takao-h

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ssssota @takao-h