max_items change

[TomAugspurger]

pystac-client 0.4.0 changed the default max_items:

import pystac_client

catalog = pystac_client.Client.open("https://planetarycomputer.microsoft.com/api/stac/v1")
search = catalog.search(collections=["goes-cmi"], query={"goes:image-type": {"eq": "FULL DISK"}, "platform": {"eq": "GOES-16"}}, datetime="2022-06-27/2022-06-29")
print(len(list(search.get_all_items())))

With pystac-client=0.3.5 that prints 430. With pystac-client=0.4.0 it prints 100.

A couple things:

1. Does pystac-client have a versioning / deprecation policy? IMO this is a pretty major change (since it affects the results) and should have gone through a deprecation first.
2. What behavior do we actually want?

I think that by default pystac-client should return the full result set, and that limiting the results should be done explicitly (the 0.3.5 behavior). By consuming the result iterator with list(), you're asking for everything.

[TomAugspurger]

Sorry, just saw @gadomski's comment at #237 (comment) which discusses max_items.

I'll close this and we can include this discussion over there.