Use typed Key in errors

Author: nightkr

crates/stackable-operator/src/kvp/key.rs

@@ -109,9 +109,10 @@ impl Display for Key {
     }
 }
 
-impl From<&Key> for String {
+// Allows SNAFU context selectors to clone the key implicitly
+impl From<&Key> for Key {
     fn from(value: &Key) -> Self {
-        value.to_string()
+        value.clone()
     }
 }
 

crates/stackable-operator/src/kvp/mod.rs

@@ -38,12 +38,8 @@ where
     InvalidKey { source: KeyError, key: String },
 
     /// Indicates that the value failed to parse.
-    #[snafu(display("failed to parse value {value:?} of key {key:?}"))]
-    InvalidValue {
-        source: E,
-        key: String,
-        value: String,
-    },
+    #[snafu(display("failed to parse value {value:?} for key {key:?}", key = key.to_string()))]
+    InvalidValue { source: E, key: Key, value: String },
 }
 
 /// A validated Kubernetes key/value pair.