Remove commons mod. Add time feature

Author: sbernauer

Cargo.lock

@@ -6,7 +6,7 @@ use const_oid::db::rfc5280::{ID_KP_CLIENT_AUTH, ID_KP_SERVER_AUTH};
 use k8s_openapi::api::core::v1::Secret;
 use kube::{Api, Client, runtime::reflector::ObjectRef};
 use snafu::{OptionExt, ResultExt, Snafu};
-use stackable_shared::{commons::secret::SecretReference, time::Duration};
+use stackable_shared::{secret::SecretReference, time::Duration};
 use tracing::{debug, instrument};
 use x509_cert::{
     Certificate,

crates/stackable-certs/src/ca/mod.rs

@@ -21,7 +21,7 @@ All notable changes to this project will be documented in this file.
 - BREAKING: Some modules have been moved into the `stackable-shared` crate, so that they can also be
   used in `stackable-certs` and `stackable-webhook` ([#1074]):
   - The module `stackable_operator::time` has moved to `stackable_operator::shared::time`
-  - The module `stackable_operator::commons::secret` has moved to `stackable_operator::shared::commons::secret`
+  - The module `stackable_operator::commons::secret` has moved to `stackable_operator::shared::secret`
 
 ### Fixed
 

crates/stackable-operator/CHANGELOG.md

@@ -8,12 +8,11 @@ edition.workspace = true
 repository.workspace = true
 
 [features]
-full = ["certs", "telemetry", "time", "versioned", "webhook"]
-default = ["telemetry", "time", "versioned"]
+full = ["certs", "telemetry", "versioned", "webhook"]
+default = ["telemetry", "versioned"]
 
 certs = ["dep:stackable-certs"]
 telemetry = ["dep:stackable-telemetry"]
-time = ["dep:time"]
 versioned = ["dep:stackable-versioned"]
 webhook = ["dep:stackable-webhook"]
 
@@ -47,7 +46,6 @@ serde_yaml.workspace = true
 serde.workspace = true
 snafu.workspace = true
 strum.workspace = true
-time = { workspace = true, optional = true }
 tokio.workspace = true
 tracing.workspace = true
 tracing-appender.workspace = true

crates/stackable-operator/Cargo.toml

@@ -6,6 +6,12 @@ license.workspace = true
 edition.workspace = true
 repository.workspace = true
 
+[features]
+full = ["time"]
+default = ["time"]
+
+time = ["dep:time"]
+
 [dependencies]
 k8s-openapi.workspace = true
 kube.workspace = true
@@ -15,7 +21,7 @@ serde.workspace = true
 serde_yaml.workspace = true
 snafu.workspace = true
 strum.workspace = true
-time.workspace = true
+time = { workspace = true, optional = true }
 
 [dev-dependencies]
 k8s-openapi.workspace = true

crates/stackable-shared/Cargo.toml

@@ -1,7 +1,8 @@
 //! This crate contains various shared helpers and utilities used across other crates in this
 //! workspace.
 
-pub mod commons;
 pub mod crd;
+pub mod secret;
+#[cfg(feature = "time")]
 pub mod time;
 pub mod yaml;

crates/stackable-shared/src/commons/mod.rs

@@ -44,7 +44,7 @@ pub mod versioned {
         pdb_config: stackable_operator::commons::pdb::PdbConfig,
         product_image: stackable_operator::commons::product_image_selection::ProductImage,
         secret_class_volume: stackable_operator::commons::secret_class::SecretClassVolume,
-        secret_reference: stackable_operator::shared::commons::secret::SecretReference,
+        secret_reference: stackable_operator::shared::secret::SecretReference,
         tls_client_details: stackable_operator::commons::tls_verification::TlsClientDetails,
 
         // Already versioned