Skip to content

Commit ab7b08e

Browse files
committed
add comment on enum
1 parent 11185cc commit ab7b08e

File tree

1 file changed

+4
-0
lines changed
  • src/commons/authentication

1 file changed

+4
-0
lines changed

src/commons/authentication/mod.rs

+4
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,10 @@ pub struct ClientAuthenticationDetails<O = ()> {
9999
/// is flattened into the final CRD.
100100
///
101101
/// Use [`ClientAuthenticationDetails::oidc_or_error`] to get the value or report an error to the user.
102+
// TODO: Ideally we want this to be an enum once other `ClientAuthenticationOptions` are added, so
103+
// that user can not configure multiple options at the same time (yes we are aware that this makes a
104+
// changing the type of an AuthenticationClass harder).
105+
// This is a non-breaking change though :)
102106
oidc: Option<oidc::ClientAuthenticationOptions<O>>,
103107
}
104108

0 commit comments

Comments
 (0)