Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent auto-scroll to iframe #1653

Closed
NetanelBasal opened this issue Nov 3, 2021 · 10 comments
Closed

Prevent auto-scroll to iframe #1653

NetanelBasal opened this issue Nov 3, 2021 · 10 comments

Comments

@NetanelBasal
Copy link

Description of Bug

When using the SDK it auto scrolls to the iframe.

Steps to Reproduce

See it live on every page here https://ngneat.github.io/elf/docs/store

Expected Behavior

Stop the auto-scroll.

@fvsch
Copy link
Contributor

fvsch commented Nov 3, 2021

Hi @NetanelBasal, thanks for the report! We’re looking into it.

@fvsch
Copy link
Contributor

fvsch commented Nov 10, 2021

Hi again @NetanelBasal. We shipped an update which seems to fix the issue on https://ngneat.github.io/elf/docs/store and other pages using StackBlitz embeds. Can you give it a try and confirm?

As a side note, I think you can make a couple tweaks to your embedding code:

  • We recently pushed an SDK update that lets you set devToolsHeight: 100. I saw that you were using devToolsHeight: 99 as a workaround. Make sure you're using the latest SDK version.
  • I would recommend using the forceEmbedLayout: true option, if you think that layout works for your use case. In a future major version of the SDK (likely 2.0), we’ll probably set the default value to true for that option.

@NetanelBasal
Copy link
Author

Yes, it works perfectly.

Great, I'll set the height to 100 and check the forceEmbedLayout option.

Thanks!

@thescientist13
Copy link

Thanks for the fix! We just observed this issue ourselves the other day and now it has gone away. 🙇‍♂️

@Char2sGu
Copy link

Char2sGu commented Apr 24, 2023

@thescientist13 The issue is not solved, it's back again. Checkout https://ngneat.github.io/elf/docs/store and you can see the page scrolls to the iframe again now!

@Enngage
Copy link

Enngage commented May 29, 2023

We are seeing the same issue, can you please add an option for disabling cursor focus?

@shhdharmen
Copy link

I am also facing same issue.

@kamranayub
Copy link

kamranayub commented Nov 16, 2023

Can also confirm it's happening (in Chrome, Firefox seems okay). Exact same issue as above.

FYI @thescientist13 it's happening for you again too at https://www.greenwoodjs.io/getting-started/quick-start/

As a workaround, I am using clickToLoad: true for now but that's not ideal, I prefer the live view 😄

@thescientist13
Copy link

seems like this is happening again?

@NielsCodes
Copy link

seems like this is happening again?

It was never fixed to begin with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants