Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link to proper referral graph + change message depending on referee account creation date #1047

Open
SatsAllDay opened this issue Apr 9, 2024 · 3 comments · May be fixed by #1211
Open

link to proper referral graph + change message depending on referee account creation date #1047

SatsAllDay opened this issue Apr 9, 2024 · 3 comments · May be fixed by #1211
Labels
bug difficulty:easy

Comments

@SatsAllDay
Copy link
Contributor

Description
Forked from this comment on #1044.

With the changes to how referrals work, notifications for new referrals show up back when the referred user was created, which means they are often not in view when you view your own notifications at /notifications.

Steps to Reproduce

  1. As user 1, follow a referral link from user 2
  2. As user 2, check your notifications, see no corresponding notification

Expected behavior
The new referral notification should be at the top of the notifications page

Screenshots
I didn't capture any.

Logs
N/A

Environment:
N/A

Additional context
@ekzyis outlined the cause of the bug here
@SatsAllDay SatsAllDay added the bug label Apr 9, 2024
@SatsAllDay SatsAllDay mentioned this issue Apr 9, 2024
Closed
@huumn
Copy link
Member

huumn commented Apr 9, 2024 •
edited
Loading

In line with our plans outlined in #1044 we will probably be removing these notifications, so I'm going to close. But if we do end up going back to the Old Ways, we'll rehydrate this.

So perhaps this issue should be about removing notifications for referrals?

@huumn huumn closed this as not planned Won't fix, can't repro, duplicate, stale Apr 9, 2024
@huumn huumn reopened this Apr 9, 2024
@ekzyis ekzyis changed the title New referral notifications aren't visible at /notifications Remove referral notifications Apr 9, 2024
@ekzyis ekzyis mentioned this issue Apr 9, 2024
Closed
@tsmith123
Copy link
Contributor

@huumn Is this a case of ripping out everything to do with noteInvites or is there a bit more to it than that?

@huumn
Copy link
Member

huumn commented May 31, 2024

Yep! That should be all that this requires.

@tsmith123 tsmith123 linked a pull request May 31, 2024 that will close this issue
Draft
@huumn huumn changed the title Remove referral notifications link to proper referral graph depending on referee account creation Sep 29, 2024
@huumn huumn changed the title link to proper referral graph depending on referee account creation link to proper referral graph + change message depending on referee account creation date Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug difficulty:easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Referral Notifications tsmith123/stacker.news
3 participants
@tsmith123 @huumn @SatsAllDay