Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if Service has Endpoints for dangling service template #747

Closed
wants to merge 8 commits into from
Closed

Check if Service has Endpoints for dangling service template #747

wants to merge 8 commits into from

Conversation

marcmognol
Copy link

Motivation

Fix #746

Changed

This PR update dangling-service template.
When no selector is specified on the Service, check if Endpoints exists in the context with the same name and namespace.

@marcmognol marcmognol requested a review from janisz as a code owner March 15, 2024 19:49
@codecov Codecov
Copy link

codecov bot commented Mar 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 72.28%. Comparing base (49aa5bb) to head (453f608).

Files Patch % Lines
pkg/templates/danglingservice/template.go 50.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
- Coverage   72.37%   72.28%   -0.10%     
==========================================
  Files          45       45              
  Lines        1937     1945       +8     
==========================================
+ Hits         1402     1406       +4     
- Misses        421      423       +2     
- Partials      114      116       +2
Flag Coverage Δ
bats ?
unit 72.28% <50.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcmognol marcmognol force-pushed the dangling-service-endpoints branch from 56ef9d3 to 6eafd64 Compare March 16, 2024 09:54
janisz
janisz requested changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@janisz janisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add sample from

@marcmognol
Copy link
Author

Hi @janisz,
Is it better now ?
Marc

@marcmognol marcmognol closed this Apr 18, 2024
@rassie
Copy link

rassie commented Sep 13, 2024

Is there a reason this has been closed? Would also be cool, if this could be extended for EndpointSlices too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janisz janisz janisz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - service has no selector specified raised when using Endpoint
3 participants
@marcmognol @rassie @janisz