Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit tests coverage for stx-transfer-memo? function #401

Open
csgui opened this issue May 7, 2024 · 4 comments
Open

Improve unit tests coverage for stx-transfer-memo? function #401

csgui opened this issue May 7, 2024 · 4 comments

Comments

@csgui
Copy link
Collaborator

csgui commented May 7, 2024

Cover unhappy path of stx-transfer-memo? function with unit tests.

https://github.com/stacks-network/clarity-wasm/blob/main/clar2wasm/src/words/stx.rs#L131

@Acaccia
Copy link
Collaborator

Acaccia commented May 7, 2024

stx-transfer-memo? and stx-transfer both use the exact same stdlib.transfer-memo wasm function. Current unit tests already cover the unhappy paths.

@csgui
Copy link
Collaborator Author

csgui commented May 7, 2024

@csgui csgui closed this as completed May 7, 2024
@github-project-automation github-project-automation bot moved this from Status: 🆕 New to Status: ✅ Done in Stacks Core Eng May 7, 2024
@Acaccia
Copy link
Collaborator

Acaccia commented May 7, 2024

My comment was not necessarily about this issue being unnecessary, but it was more the fact that the current tests could be copied for stx-transfer-memo?.

I think it's important to add them in case we refactor those functions later, so I'll reopen this issue.

@Acaccia Acaccia reopened this May 7, 2024
@github-project-automation github-project-automation bot moved this from Status: ✅ Done to Status: 🆕 New in Stacks Core Eng May 7, 2024
@csgui
Copy link
Collaborator Author

csgui commented May 7, 2024

I think it's important to add them in case we refactor those functions later, so I'll reopen this issue.

Oh, I see! I misunderstood your comment. Thanks!

@smcclellan smcclellan added this to the WASM Phase 2 milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Status: 🆕 New
Development

No branches or pull requests

3 participants