Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Coordinator filters withdrawal requests using consensus rules #1321

Open
1 task
djordon opened this issue Feb 7, 2025 · 0 comments
Open
1 task
Labels
sbtc signer binary The sBTC Bootstrap Signer. withdrawal The withdrawal sBTC operation.

Comments

@djordon
Copy link
Collaborator

djordon commented Feb 7, 2025

Feature - Coordinator filters withdrawal requests using consensus rules

1. Description

The consensus rules for withdrawal requests are detailed in #741. The coordinator must filter the proposed withdrawal requests to be in line with these rules or else the sweep transaction will be rejected when going through validation with peer signers.

1.1 Context & Purpose

The coordinator selects the withdrawal requests to include in a sweep. If it includes a one “bad” request, the signers will reject the sweep transaction, affecting all requests that would be included in the sweep. So the coordinator needs to follow consensus rules when picking requests.

2. Technical Details:

An individual withdrawal request will validate through sbtc consensus rules if it’s WithdrawalRequestReport passes validation. The work for building the report is associated with #1308, while this ticket can be accomplished by using the report in the coordinator code path.

2.1 Acceptance Criteria:

  • The coordinator uses consensus rules for filtering withdrawal requests

3. Related Issues and Pull Requests (optional):

4. Appendix

There are collective cap rules around withdrawals, where we may want to throttle the system so that not too much is withdrawn per bitcoin block. We haven't formalized what those rules should be, so that part of consensus rules doesn't need to be done with this ticket.

@djordon djordon added sbtc signer binary The sBTC Bootstrap Signer. withdrawal The withdrawal sBTC operation. labels Feb 7, 2025
@djordon djordon added this to sBTC Feb 7, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Feb 7, 2025
@djordon djordon moved this from Needs Triage to Todo in sBTC Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sbtc signer binary The sBTC Bootstrap Signer. withdrawal The withdrawal sBTC operation.
Projects
Status: Todo
Development

No branches or pull requests

1 participant