Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore]: Proper coinbase generation in dummy block generator #213

Closed
netrome opened this issue May 30, 2024 · 0 comments · Fixed by #253
Closed

[Chore]: Proper coinbase generation in dummy block generator #213

netrome opened this issue May 30, 2024 · 0 comments · Fixed by #253
Assignees
@netrome
Labels
sbtc signer binary The sBTC Bootstrap Signer.

Comments

@netrome
Copy link
Contributor

netrome commented May 30, 2024 •
edited
Loading

Context

The testing::dummy::block function currently generates blocks with an invalid coinbase transaction. It currently does the bare minimum to allow the Block::bip34_block_height method to succeed, which is needed for the block observer tests. However, this can lead to unintentional problems going forward so we should ensure that we create a proper coinbase transaction in this utility function.

Definition of done

The testing::dummy::block function creates a proper coinbase transaction for the block.
@netrome netrome added refine sbtc signer binary The sBTC Bootstrap Signer. and removed refine labels May 30, 2024
@netrome netrome added this to sBTC May 31, 2024
@netrome netrome moved this to Todo in sBTC May 31, 2024
@netrome netrome moved this from Todo to In Progress in sBTC Jun 20, 2024
@netrome netrome self-assigned this Jun 20, 2024
@netrome netrome mentioned this issue Jun 24, 2024
Merged
@netrome netrome linked a pull request Jun 24, 2024 that will close this issue
feat: Proper coinbase generation #253
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in sBTC Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netrome netrome

Labels
sbtc signer binary The sBTC Bootstrap Signer.
Projects
sBTC
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Proper coinbase generation stacks-network/sbtc
1 participant
@netrome