Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add functions for validating deposit prevouts #738

Closed
1 task
djordon opened this issue Oct 30, 2024 · 0 comments · Fixed by #749
Closed
1 task

[Feature]: Add functions for validating deposit prevouts #738

djordon opened this issue Oct 30, 2024 · 0 comments · Fixed by #749
Assignees
Labels
sbtc signer binary The sBTC Bootstrap Signer.

Comments

@djordon
Copy link
Collaborator

djordon commented Oct 30, 2024

Feature - Add functions for validating deposit prevouts

1. Description

This is a subtask of #286.

There are a bunch of properties that need to be checked for each deposit input. Add functions that can help check these properties during validation.

1.1 Context & Purpose

Each bitcoin sweep transaction has 4 different parts that need validating:

  1. deposit inputs,
  2. withdrawal outputs,
  3. signer TXO input,
  4. signer UTXO outputs (one regular UTXO and one OP_RETURN TXO).

This ticket is for helping with (1).

2. Technical Details:

2.1 Acceptance Criteria:

  • Add helper functions for validating deposit inputs.

3. Related Issues and Pull Requests (optional):

@djordon djordon added the sbtc signer binary The sBTC Bootstrap Signer. label Oct 30, 2024
@djordon djordon added this to the sBTC: Deposit ready milestone Oct 30, 2024
@djordon djordon self-assigned this Oct 30, 2024
@djordon djordon added this to sBTC Oct 30, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Oct 30, 2024
@djordon djordon changed the title [Feature]: Add functions for validating the deposit inputs [Feature]: Add functions for validating deposit inputs Oct 30, 2024
@djordon djordon changed the title [Feature]: Add functions for validating deposit inputs [Feature]: Add functions for validating deposit inputs to bitcoin transactions Oct 30, 2024
@djordon djordon changed the title [Feature]: Add functions for validating deposit inputs to bitcoin transactions [Feature]: Add functions for validating deposit inputs to transactions Oct 30, 2024
@djordon djordon changed the title [Feature]: Add functions for validating deposit inputs to transactions [Feature]: Add functions for validating deposit prevouts Oct 30, 2024
@djordon djordon moved this from Needs Triage to In Progress in sBTC Oct 30, 2024
@djordon djordon moved this from In Progress to In Review in sBTC Oct 31, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in sBTC Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sbtc signer binary The sBTC Bootstrap Signer.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant