Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neon integration-style test for epoch 2.4 #3715

Merged
merged 4 commits into from
May 22, 2023
Merged

Neon integration-style test for epoch 2.4 #3715

merged 4 commits into from
May 22, 2023

Conversation

pavitthrap
Copy link
Contributor

@pavitthrap pavitthrap commented May 12, 2023 •
edited
Loading

Description

  • Added two neon integration style tests for epoch 2.4.
  • Fixed a bug in the reward set calculation function - it would error if the epoch 2.4 boundary was crossed but if the pox-3 contract was uninitialized (which occurs if there is no Stacks block).

pavitthrap added 2 commits May 11, 2023 14:20
@pavitthrap
added epoch2.4 test
2ac5cee 
disable_pox_v2 is failing only on final assertion, not crashing

wip, trying to get epoch 2.4 to start right

rename test, revert epoch_22

fix_to_pox_contract passes

auto unlock test passing

added more asserts for auto unlock test
@pavitthrap
fixed test, added to gh workflow
5f8c914
@codecov
Copy link

codecov bot commented May 12, 2023 •
edited
Loading

Codecov Report

Merging #3715 (390ff2e) into feat/epoch-2.4 (869a6b1) will decrease coverage by 6.21%.
The diff coverage is 0.17%.

@@                Coverage Diff                 @@
##           feat/epoch-2.4    #3715      +/-   ##
==================================================
- Coverage           31.25%   25.05%   -6.21%     
==================================================
  Files                 301      301              
  Lines              283315   284808    +1493     
==================================================
- Hits                88556    71352   -17204     
- Misses             194759   213456   +18697
Impacted Files Coverage Δ
testnet/stacks-node/src/tests/epoch_24.rs 0.00% <0.00%> (ø)
testnet/stacks-node/src/tests/mod.rs 53.82% <ø> (-1.51%) ⬇️
testnet/stacks-node/src/tests/neon_integrations.rs 40.56% <0.00%> (-42.89%) ⬇️
src/chainstate/stacks/boot/mod.rs 9.05% <33.33%> (-0.04%) ⬇️

... and 139 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pavitthrap pavitthrap changed the title Test/neon epoch 2.4 v2 Neon integration-style test for epoch 2.4 May 15, 2023
kantai
kantai approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- the broken unit tests are fixed upstream, so I wouldn't worry about that.

@kantai kantai requested a review from obycode May 19, 2023 19:02
obycode
obycode approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one minor comment.

testnet/stacks-node/src/tests/epoch_24.rs Show resolved Hide resolved
@pavitthrap pavitthrap merged commit 81c251b into feat/epoch-2.4 May 22, 2023
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@obycode obycode obycode approved these changes

@kantai kantai kantai approved these changes

Assignees
No one assigned
Labels
locked
Projects
Stacks Core Eng
Status: Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pavitthrap @blockstack-devops @kantai @obycode