Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BurnchainParameters TOML-configurable.. possibly even PoxConstants #3417

Closed
gregorycoppola opened this issue Nov 21, 2022 · 3 comments
Closed
Labels

Comments

@gregorycoppola
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Right now, BurnchainParameters is not TOML configurable.
https://github.com/stacks-network/stacks-blockchain/blob/a0393e47452ae45eea645d792717d41035320961/src/burnchains/mod.rs#L98

This can be difficult for running a custom testnet (like for Stacks 2.1), because you might want to change first_block_height on the fly when trying out new test nets.

The same could arguably be said for PoxConstants, for which we recently wanted to set v1_unlock_height.

The call stacks for BurnchainParameters::from_params and PoxConstants::new are documented in #3411

Describe the solution you'd like
Make BurnchainParameters configurable in the TOML file, and maybe even PoxConstants.

Describe alternatives you've considered
The current way to configure BurnchainParameters is to change the Rust code.

Additional context
#3411

@gregorycoppola gregorycoppola changed the title Make BurnchainParameters configurable.. possibly even PoxConstants Make BurnchainParameters TOML-configurable.. possibly even PoxConstants Nov 21, 2022
@jcnelson
Copy link
Member

I'm already working on this in #3409

@jcnelson
Copy link
Member

jcnelson commented Dec 5, 2022

The parts of PoxConstants that need to be changeable are in #3409.

In general, there's no need to make BurnchainParameters configurable. Those are meant to be constants. If you need to spin up a dedicated testnet that doesn't talk to the main testnet, then you really should do so in a separate PR so we don't confuse users.

@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants