Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Degradation in 2.1.0.0.3 #3671

Open
CharlieC3 opened this issue Apr 18, 2023 · 5 comments
Open

Performance Degradation in 2.1.0.0.3 #3671

CharlieC3 opened this issue Apr 18, 2023 · 5 comments
Assignees
Labels
icebox Issues that are not being worked on

Comments

@CharlieC3
Copy link
Member

CharlieC3 commented Apr 18, 2023

Describe the bug
Based on our metrics, we're seeing a large regression in HTTP response time performance when we upgraded from 2.1.0.0.2 to 2.1.0.0.3 for stacks blockchain nodes receiving HTTP traffic.

We upgraded our nodes around 1500ET on April 17th. CPU and memory usage has stayed the same before and after the upgrade.

HTTP GET response time increased for 200s and 404s. Some affected endpoints I've seen are:

  • /v2/accounts/*
  • /v2/info
  • /v2/pox
    Screenshot 2023-04-18 at 11 42 29 AM
    Screenshot 2023-04-18 at 11 42 57 AM

HTTP POST response time increased for 200s and 400s. Some affected endpoints I've seen are:

  • /v2/transactions
  • /v2/contracts/call-read/* (lots of different contracts affected, not just one or a few in particular)
  • /v2/map_entry/SP000000000000000000002Q6VF78/pox/delegation-state?proof=0
  • /v2/fees/transaction

Screenshot 2023-04-18 at 11 43 24 AM
Screenshot 2023-04-18 at 11 43 50 AM

@kantai
Copy link
Member

kantai commented Apr 18, 2023

I'll look through our logs to try to see what's driving the performance issues here, but I'm very skeptical that this could be related to 2.1.0.0.3 -- the patch did not touch any codepaths used by follower nodes.

@pavitthrap
Copy link
Contributor

Performance degradations went away after API release was downgraded. It seems like the issue did not emerge from the node upgrade.

More analysis needed.

@pavitthrap pavitthrap added the icebox Issues that are not being worked on label Apr 25, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Stacks Core Eng Aug 4, 2023
@AshtonStephens
Copy link
Collaborator

AshtonStephens commented Sep 7, 2023

First, @kantai you said:

I'll look through our logs to try to see what's driving the performance issues here, but I'm very skeptical that this could be related to 2.1.0.0.3 -- the patch did not touch any codepaths used by follower nodes.

Then @pavitthrap you said:

Performance degradations went away after API release was downgraded.

This sounds like the issue was caused by the API release upgrade. Am I misunderstanding something? Is it possible that the upgrade causes a memory issue or something else on the hosts that could tangentially cause large http times?

@kantai
Copy link
Member

kantai commented Sep 7, 2023

Pretty unlikely -- the stacks-blockchain-api itself isn't handling these requests: these are being handled by the stacks-node RPC handler. My best guess is that request patterns changed a little bit which led to a change in the performance of the node.

@CharlieC3
Copy link
Member Author

Also adding some further perspective, this issue does not mark the first of "poor HTTP performance" for the stacks-node. Rather it should be interpreted as a time when things went from poor to worse.
Agreed with @kantai's statement that this may have been a result of a change in user behavior; it's unclear to me and given the issue's age we likely won't be able to extract any more contextual data from that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icebox Issues that are not being worked on
Projects
Status: Status: 🆕 New
Development

No branches or pull requests

4 participants