[RFC] Add Function.bind, Array.map, and Array.filter polyfills for legacy browsers #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Imo it would be better to not include polyfils as part of this library. Doing so woul penalise users of modern browsers and the ones that are including one already. Maybe it would be enough to point people to a polyfil or keep a minimal polyfil as a separate file. |
|
@pkozlowski-opensource Given this PR there is very, very little cost for modern browsers or others who're using shims because we don't redefine necessary functions if they're defined. I strongly believe we should polyfill because I want stacktrace.js to "just work" in legacy envs. I think mostly I hope to decide whether we should |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ES5 polyfills inline instead of depending on a shim library.