Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add views for step and wizard #102

Closed
nesnoj opened this issue Jun 24, 2024 · 4 comments · Fixed by #122
Closed

Add views for step and wizard #102

nesnoj opened this issue Jun 24, 2024 · 4 comments · Fixed by #122
Assignees
Labels
enhancement New feature or request

Comments

@nesnoj
Copy link

nesnoj commented Jun 24, 2024

Currently there are no steps, hit it!

Create views for app flow:
image

Like the wizard from EPP app but use views instead of doing it the JS way

@nesnoj nesnoj added the enhancement New feature or request label Jun 24, 2024
@josihoppe
Copy link
Collaborator

@nesnoj RIght now there are the following views: home, map, details, parameters, results, robustness
I am a little bit confused, because the current order of results/robustness is different then in the app flow and also the page for robustness seems to me like its doing something different right now. Could you check if the results and robustness pages are doing what they are supposed to be doing or if they need to be changed or even new pages added to gain the structure of the app flow?

@josihoppe josihoppe linked a pull request Aug 8, 2024 that will close this issue
@josihoppe
Copy link
Collaborator

@nesnoj I had a question about the placement of the buttons.
Should they be on top in the header as previous/next Buttons on the sides of the vizwar (version 1 in picture)
Or should there be next-Buttons on the page itself, placed underneath the content where the user is supposed to interact? (version 2)

Bildschirmfoto zu 2024-08-20 11-10-47

@nesnoj
Copy link
Author

nesnoj commented Aug 21, 2024

Thx @josihoppe for working on this!

Good point.
I prefer version 1 as the left panel might gets too packed in some steps. Also, the layout may change in later steps (no left panel).

@josihoppe
Copy link
Collaborator

Thx @josihoppe for working on this!

Good point. I prefer version 1 as the left panel might gets too packed in some steps. Also, the layout may change in later steps (no left panel).

That change will be merged with #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants