Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rely on multi-language tabs-panel being present #74

Merged
merged 1 commit into from
May 16, 2023
Merged

Don't rely on multi-language tabs-panel being present #74

merged 1 commit into from
May 16, 2023

Conversation

carlobeltrame
Copy link
Contributor

On decidim organizations which have only one language activated, the editors are not wrapped into .tabs-panel elements. On these platforms, the proposal answer template body was not being filled in, because the editor was not found.

Fixes stadtluzern/decidim-ocl#269

On decidim organizations which have only one language activated, the editors are not wrapped into .tabs-panel elements. On these platforms, the proposal answer template body was not being filled in, because the editor was not found.
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (eae8d19) 98.16% compared to head (f3559e3) 98.16%.

❗ Current head f3559e3 differs from pull request most recent head 0d111ce. Consider uploading reports for the commit 0d111ce to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files          73       73           
  Lines        1310     1310           
=======================================
  Hits         1286     1286           
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@microstudi microstudi merged commit caa6168 into openpoke:main May 16, 2023
@carlobeltrame carlobeltrame deleted the patch-1 branch May 16, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vorlagen - Text wird nicht übernommen
2 participants