Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy signatures: validate against previous_transactions as a failure mode, with warning #41

Open
orthecreedence opened this issue Feb 19, 2024 · 0 comments
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed project:cli

Comments

@orthecreedence
Copy link
Member

orthecreedence commented Feb 19, 2024

When validating a policy signature, we currently take the creating identity's currrent transaction list and validate the signature against it. This is mostly fine, but if the policies or admin keys have changed since the signature was created, it could invalidate the signature. Because SignV1 transactions track their position in the DAG via previous_transactions, it makes sense to reset that identity to the latest of the transactions in that prev list and try the validation again. If it succeeds, we warn the user "this signature was not valid against the current version of the identity, but was valid against a past version."

@orthecreedence orthecreedence added feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed project:cli labels Feb 19, 2024
@orthecreedence orthecreedence changed the title Identity signatures: validate against previous_transactions as a failure mode, with warning Policy signatures: validate against previous_transactions as a failure mode, with warning May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed project:cli
Projects
None yet
Development

No branches or pull requests

1 participant