Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction staging: don't assume an identity exists (ie, allow staging of genesis transaction) #42

Open
orthecreedence opened this issue Feb 20, 2024 · 0 comments
Labels
bug Something isn't working project:aux project:cli

Comments

@orthecreedence
Copy link
Member

In a few places, we assume that when staging transactions we'll have an identity ID. This holds true not just for the commands in the CLI but also the aux library's stage functions.

This assumption is false, because it's entirely plausible and acceptable to use the staging system to create a multiparty group identity. This needs to be fixed.

That said, having all staged transactions in one big pool seems like a step backward in terms of UX, so maybe assigning an identity_id if we have it, but allowing null if we don't is a good compromise, and in the cli making the identity id optional, or add an argument for "has no identity id."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working project:aux project:cli
Projects
None yet
Development

No branches or pull requests

1 participant