-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.0 Release #475
Comments
Hey @WardBrian can I do this now or should I wait for the others (math, stan, cmdstan ) release first ? |
IMO we can do it whenever |
Did we decide whether or not to do a RC, @mitzimorris ? |
Will Edit: reading your post from another issue, pypi will do the right thing. Not sure about conda |
Conda will be up to me to get right, or we just won't release the rc on conda and wait for 1.0 there |
I think conda will be fine too, while reading this doc they point to the pypi versioning scheme |
Yes, the conda-forge KB also says this https://conda-forge.org/docs/maintainer/knowledge_base.html#pre-release-builds Should be possible, just have to make sure I get all the settings right when things propagate |
I say we might as well run a 1.0.0rc1 build today. Not sure how long we will want to wait, a week maybe? |
Usually we do the rc then code freeze for one week |
excellent plan - let's do it! |
|
Release is now complete, RTD seems fine: https://readthedocs.org/projects/cmdstanpy/versions/ |
Seems like the actual site doesn't work properly: https://cmdstanpy.readthedocs.io/ |
rtd build is done: https://cmdstanpy.readthedocs.io/en/v1.0.0rc1/ |
looks good on my machine - many thanks! |
RC1 is on conda-forge now |
downloaded from conda-forge, ran a notebook and exported results to arviz and no problems. |
looking at the dependencies - gamestonk terminal has detailed install instructions - we should do something similar. |
Weirdly it seems like they don't actually depend on us, at least not any more. I wouldn't say their instructions are any more detailed than ours, they just require a lot of extra steps for their use case. I think we should link to the conda installation instructions on our page, but the rest of their instructions are unnecessary for us |
Just to confirm, we're good to go for 1.0 release tomorrow? @mitzimorris |
I was slow to get the announcment up on the forums. right now I'm seeing only 16 downloads on conda-forge so far. |
Hard to say. PyPi (pip) is easier to install rcs through, but harder to get download stats out of, so it's unclear how many people are actually using it. Happy to wait another week as well, so that the release comes after our meeting with the CmdStanR devs |
I drew up an overview of everything deprecated that was removed - https://discourse.mc-stan.org/t/cmdstanpy-1-0-0rc1/24973/2?u=mitzimorris next up - filing FYI issues on Prophet and Arviz et al. |
Do we think 1.2 million downloads in the last month is correct? On the main CRAN mirror, Edit: matplotlib last 30 days: 33,046,236. ggplot2 last 30 days: 3,294,429 Maybe Python is just way more popular across the board? |
Prophet does pin us, but it isn't downloaded that much: Really odd. I think the numbers are probably correct (Google BigData seems like they'd know how to count) but I have no clue where they'd be coming from. According to pepy (and any other site) we got more downloads this month than |
no clue, but those are the stats. CmdStanPy and PyStan are both way up there. lotta Python users? lotta AWS instances running production pipelines? |
OK, after some digging, SO and pypi say that internal mirrors might explain what we're seeing - python docs: https://packaging.python.org/guides/analyzing-pypi-package-downloads/
old SO post: https://stackoverflow.com/questions/9648015/pypi-download-counts-seem-unrealistic FWIW, Google Colab notebooks now include, CmdStanPy (0.9.5), PyStan (2.19), and fbprophet . |
I was looking at the package so yes, that probably is our number of downloads, just not the number of users most likely |
let's release 1.0 next Tuesday - Nov 2nd. |
Do we want to patch #486 first? It should be a very simple change |
sure - could you do this? |
Sounds good. For arviz do we need to check anything special? |
Note: We will now be doing a rc2 and delaying the release until #436 |
Please let me know if/when I need to run the rc2 or if I can help with anything here. |
Thanks Nic, will do. It will probably be at least a couple days or so to get #436 good to go |
So @mitzimorris how do you feel about cutting a RC2? If we mostly have doc left to write we can do that during the release period, but if we think there are more changes could be good to wait? |
Yes!!!! |
@ahartikainen - noticed Arviz issue w/ cmdstanpy - is there anything needed from our side? arviz-devs/arviz#1646 (comment) |
rc2 is out on pypi, conda will follow (probably tomorrow) |
slouching towards Beta - https://discourse.mc-stan.org/t/cmdstanpy-1-0-0rc2/25337 |
On conda now |
#499 is simple but important enough that I think we should cut rc3 when it's patched. It won't need a conda version, as it only effects non-conda installs. |
Do we want to release 1.0 this week? Latest rc will have been out for 2 weeks on Thursday |
yes!!! |
@rok-cesnovar @jgabry - OK if we do a 1.0 CmdStanPy release tomorrow? (Dec 1) |
I think we should do it tomorrow (Dec 2) so that the RC had a full 2 weeks. We should also note in the release forum/blog post that 1.0.0 is supported on Python 3.6 through 3.10, but future versions will require 3.7 (I think it's pretty unlikely we fit in a 1.1 in the next 20 days before 3.6 hits EOL) |
here's a blurb - it's a bit dry: Announcing version 1.0 of CmdStanPy! CmdStanPy is now available via Conda Forge: https://anaconda.org/conda-forge/cmdstanpy Reasons to use CmdStanPy:
CmdStanPy provdes access to the Stan compiler, inference algorithms, and diagnostics. |
I think the blurb is good! I'd also add a link to the repo and docs homepage |
This is intended as the final item in the 1.0 release project
Oct. 19
1.0.0rc1
Early November
After #436
1.0.0rc2
One week later
1.0.0
The text was updated successfully, but these errors were encountered: