Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Correctness Checking Between PPLs #261

Open
JasonPekos opened this issue Jun 14, 2024 · 0 comments
Open

Discussion: Correctness Checking Between PPLs #261

JasonPekos opened this issue Jun 14, 2024 · 0 comments

Comments

@JasonPekos
Copy link

Rationale:

It would be handy to have some sort of infrastructure for ensuring model implementations in different PPLs are equivalent.

Idea:

Evaluate the log-density over the reference draws, to see if the implementations line up. Intuitively, this may be possible with, e.g.

Problems:

  • Stan seems to only allow log density calculations on unconstrained space. For the log posteriors to be the same, the PPLs need to be using the same bijections, both for this, as well as for things like ordered transforms.
  • For more complicated models, factors out of our control --- like slightly different results from diffeq solvers --- could make the results no longer line up. This should not impact most models.
  • Not all models have reference draws, but in this case we could use something like "evaluation draws". doesn't seem like a big issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant