Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate all Fn* internal_fn variant FunApps as CompilerInternal #151

Closed
seantalts opened this issue Jun 6, 2019 · 1 comment
Closed
Labels
cleanup Code simplification or clean-up good first issue Good for newcomers

Comments

@seantalts
Copy link
Member

Matthijs pointed out in #149 that it's a bit difficult to read the code for generating stuff when you deal with all of the variants in internal_fn in a variety of different places depending on which function it is. We should move to all of these being labeled CompilerInternal, and possibly delete some of them from the variant and just use the StanLib function name where appropriate.

The motivating example was that negative_infinity is actually a StanLib funcction and we'd construct it in the compiler using the StanLib function kind and the FnNegInf variant. But perhaps the thing to actually do is just use the actual string negative_infinity and not create an internal_fn variant for it? OR to call it CompilerInternal and pretend that it doesn't have a StanLib equivalent. I'm not sure. What do you all think? I'm leaning towards one of those two options now - having these special variants sometimes labeled StanLib and sometimes CompilerInternal is not helpful.

@seantalts seantalts changed the title Make all Fn* stuff actually labeled as CompilerInternal Generate all Fn* internal_fn variant FunApps as CompilerInternal Jun 6, 2019
@seantalts seantalts added cleanup Code simplification or clean-up good first issue Good for newcomers labels Jun 12, 2019
@WardBrian
Copy link
Member

Done by #856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code simplification or clean-up good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants