Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

query/hash in URL doesn't cause re-evaluation #41

Closed
bmeck opened this issue Aug 14, 2017 · 4 comments
Closed

query/hash in URL doesn't cause re-evaluation #41

bmeck opened this issue Aug 14, 2017 · 4 comments

Comments

@bmeck
Copy link

bmeck commented Aug 14, 2017

Resolution on pathname is correct, but doesn't re-evaluate

// a.mjs
import assert from 'assert';
import one from './b';
import two from './b?2';
import three from './b#3';
assert.strictEqual(one, 1);
assert.strictEqual(two, 2);
assert.strictEqual(two, 3);
assert.strictEqual(global.v, 3);
// b.mjs
global.v = global.v || 0;
export default ++global.v;
@jdalton
Copy link
Member

jdalton commented Aug 14, 2017

Thanks @bmeck!

I didn't know it should cause re-evaluation. I thought maybe they were just stripped out.
Is re-evaluation covered in the EPS docs?

@bmeck
Copy link
Author

bmeck commented Aug 14, 2017

it is covered more thoroughly on the web doc, but it is in EP since URL matching is from web spec.

https://url.spec.whatwg.org/#url-equivalence

https://html.spec.whatwg.org/multipage/webappapis.html#resolve-a-module-specifier and EP don't set those flags to ignore query/hash.

@jdalton
Copy link
Member

jdalton commented Aug 14, 2017

🆒

@jdalton
Copy link
Member

jdalton commented Aug 15, 2017

Closed by b56ce4e.
I'll be adding a round of unit tests over the next couple of days to solidify support.

@jdalton jdalton closed this as completed Aug 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants