Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Getting TypeError: Illegal invocation error with esm@3.0.73 #541

Closed
borisding opened this issue Aug 3, 2018 · 1 comment
Closed

Getting TypeError: Illegal invocation error with esm@3.0.73 #541

borisding opened this issue Aug 3, 2018 · 1 comment
Labels

Comments

@borisding
Copy link

Hi!

I'm getting error from uuid package after upgrading to v3.0.73.

Repro link: https://github.com/borisding/repro-esm-uuid

OS: Windows 10
Node: v8.10.0
Error:

TypeError: Illegal invocation

There is no issue with version v3.0.72

Thanks!

@jdalton
Copy link
Member

jdalton commented Aug 3, 2018

Thanks @borisding!

I can reproduce this in Node 8, but not Node 10. It looks like a bug in our minified build.

Update:

I regressed the minified build with this commit aa358ae because it needs a side-effect as mentioned in commit 6ab4d93.

I'll add a code comment to not remove it again (I keep wanting to simplify that check 😊).

Update:

v3.0.74 is released 🎉

Update:

@dnalborczyk If you pick this needs tests up a scenario test for the uuid package would cover it. Before publishing the tests are ran minified.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

3 participants