Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

3.2.23 and 3.2.24 broken #807

Closed
steida opened this issue May 16, 2019 · 10 comments
Closed

3.2.23 and 3.2.24 broken #807

steida opened this issue May 16, 2019 · 10 comments
Labels

Comments

@steida
Copy link

steida commented May 16, 2019

Now sure why yet, but 3.2.22 works.

Investigating...

@dnalborczyk
Copy link
Contributor

hey @steida before you digg too deep, it's likely a duplicate of: #803 #804

@djMax
Copy link

djMax commented May 16, 2019

This is very much still broken, and 803 and 804 claim it as closed.

@dnalborczyk
Copy link
Contributor

@djMax there still seems to be a "leftover" regression regarding computed property names.

@djMax
Copy link

djMax commented May 16, 2019

I would consider unpublishing 23 and 24.

@tomlinton
Copy link

Same experience with broken computed property names.

@dnalborczyk
Copy link
Contributor

dnalborczyk commented May 17, 2019

@jdalton repro:

export class Foo {
  ["bar"]() {}  // not working
}

marking as "new" bug, since it was mentioned in the other [closed] thread.

@gr2m
Copy link

gr2m commented May 17, 2019

I just run into the same problem, here is my minimal test case: https://github.com/gr2m/esm-bug

// index.js
require = require("esm")(module/*, options*/)

const { MyClass }= require("./module.js")
const mc = new MyClass()
mc[Symbol.iterator]()

// module.js
export class MyClass {
 [Symbol.iterator]() {
   console.log('test')
 }
}

@jdalton
Copy link
Member

jdalton commented May 17, 2019

esm v3.2.25 is released 🎉

@gr2m
Copy link

gr2m commented May 17, 2019

That fixed it for me, cheers 👍

@steida
Copy link
Author

steida commented May 17, 2019

Fixed here as well. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

6 participants