Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve eslint config and plugins manually #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Flet
Copy link
Member

@Flet Flet commented Jun 15, 2021

fixes #27

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[💋] Bug fix
[ ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)

  • Resolve exact locations of extended config files.
  • Add resolvePluginsRelativeTo: true to eslint config to ensure plugins resolve correctly.

Which issue (if any) does this pull request address?
#27

Is there anything you'd like reviewers to focus on?

@Flet
Copy link
Member Author

Flet commented Jun 16, 2021

Well shoot. this seems to not work if there are any plugins specified in a local .eslintrc.json file. Its trying to resolve the plugins relative to the standardx __dirname. Unfortunately not seeing a way to resolve individual plugins to with different paths.

@r3dm4n
Copy link

r3dm4n commented Jun 19, 2021

Solved this by deleting my old .eslintrc.js re-running yarn lint from the command line.
Next automatically added the new eslintrc.json file

@tcurdt
Copy link

tcurdt commented Aug 3, 2021

Any progress on merging this? We are still stuck with #27

Copy link

@Raynos Raynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes. It works for me.

Copy link

@neverabsolute neverabsolute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved this by deleting my old .eslintrc.js re-running yarn lint from the command line.
Next automatically added the new eslintrc.json file

did this and it worked great

@KidkArolis
Copy link

Might be possible to fix with the new FlatConfig .. https://eslint.org/blog/2022/08/new-config-system-part-2/
Of course, depends on how everything else will migrate to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Error: Failed to load config "standard" to extend from.
6 participants