Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension to Open VSX Registry #111

Closed
jharmer95 opened this issue Jun 24, 2020 · 11 comments · Fixed by #142
Closed

Add extension to Open VSX Registry #111

jharmer95 opened this issue Jun 24, 2020 · 11 comments · Fixed by #142
Assignees

Comments

@jharmer95
Copy link

What version of this package are you using?
N/A

What problem do you want to solve?
StandardJS is only available on the Microsoft VSCode Marketplace. This prevents it from being used by open-source versions of VSCode (i.e. VSCodium, Theia).

What do you think is the correct solution to this problem?
Also publish the extension to Open VSX, guide available here

Are you willing to submit a pull request to implement this change?
N/A

@EchedelleLR
Copy link

I am interested too

@EchedelleLR
Copy link

EchedelleLR commented Aug 1, 2020

As pointed by other users who requested it for their favourite extensions "It is unclear if it's legal to use the official Microsoft extension marketplace on VS Code forks, see here" so would be more beneficial in general to have it on Open VSX.

@theoludwig
Copy link
Contributor

Apparently, the extension is published to Open VSX Registry by @markwylde
Link : https://open-vsx.org/extension/markwylde/vscode-standardjs

@markwylde
Copy link

Apparently, the extension is published to Open VSX Registry by @markwylde
Link : https://open-vsx.org/extension/markwylde/vscode-standardjs

Yeah Divlo, I have published it temporarily, but would love to delete it in favour of an official one from the standard team.

@markwylde
Copy link

Updated to 1.4.0

Let me know if there's any problems.

@feross
Copy link
Member

feross commented Nov 26, 2020

Cool, happy to publish an official version to Open VSX if it's not too much extra work. It looks like they're changing the publishing process in December 2020 so I want to wait until that's finished before figuring out the process. https://github.com/eclipse/openvsx/wiki/Publishing-Extensions

@feross feross self-assigned this Nov 26, 2020
@markwylde
Copy link

markwylde commented Dec 23, 2020

@feross openvsx has now been transferred to eclipse and the new process is in effect. I've just gone through the pairing process, and it worked.

So if you do have a few minutes free one day, you should be able to register and publish the extension. If you need any help, please feel free to reach out.

Make sure to "claim" [1] the standard namespace, so no one else can publish under the name "standard".

Also once it's published, I'll remove the version I've uploaded to avoid any confusion.

  1. https://github.com/EclipseFdn/open-vsx.org#claiming-namespace-ownership

@theoludwig
Copy link
Contributor

theoludwig commented Dec 23, 2020

I guess, we could have some Continuous Deployment (CD) for automatically publishing to the 2 marketplaces automatically when we create a new release ("tag") on GitHub.

Also the branch on master isn't working for standard engine since #140, because the changes were indeed working for standard but it wasn't for ts-standard that needed a tsconfig.json file to work, so I tried a workaround in #139, and add a small condition to only do the thing with standard engine, but it seems like it brokes everything (my bad).
So in the #142 PR, I revert the #140 PR and now everything is working as expected for every engines but obviously, we don't solve the #140 PR.

We could first merge #142, and then release v1.5.0 on both marketplace. 👍

EDIT: in #142 PR, I implemented automated deployment to deploy to both VSCode Marketplace and Open VSX automatically.

@theoludwig theoludwig linked a pull request Feb 3, 2021 that will close this issue
4 tasks
@theoludwig theoludwig mentioned this issue Feb 3, 2021
4 tasks
@jharmer95
Copy link
Author

Awesome, thanks!

@theoludwig
Copy link
Contributor

Thanks for your help! @markwylde
Could you please, remove your version of the extension to open-vsx registry, thanks!
The extension is now available here: https://open-vsx.org/extension/standard/vscode-standard

@markwylde
Copy link

I've requested the removal now. Thanks @divlo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants