Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add a HEX-BackgroundColor option for the TokenVault entries #26

Closed
h0jeZvgoxFepBQ2C opened this issue Jun 26, 2020 · 12 comments · Fixed by #49
Closed

Please add a HEX-BackgroundColor option for the TokenVault entries #26

h0jeZvgoxFepBQ2C opened this issue Jun 26, 2020 · 12 comments · Fixed by #49
Labels
enhancement New feature or request

Comments

@h0jeZvgoxFepBQ2C
Copy link

It would be great if you could add a background-color option (hex code) for the TokenVault-Entries, since I have a lot of entries which I use. Specifying a background color would help me a lot to find the corresponding entry much faster?

I also don't think that this would be hard to implement?

@JaspalSuri
Copy link

JaspalSuri commented Jun 27, 2020

Thanks for the feedback! I'll pass it along for review! As an Authy user, I can see how this would be pretty useful.

@moughxyz
Copy link
Member

What about a search/filter box? Colors would look good in one theme but not in another.

@TheodoreChu
Copy link
Contributor

Background colors per-entry are probably not too difficult to implement. One way to do it would be by adding inline styling to AuthEntry.js

@h0jeZvgoxFepBQ2C
Copy link
Author

h0jeZvgoxFepBQ2C commented Jun 29, 2020

A search filter is nice, but no replacement for the colors, since you have to reach the keyboard instead of just scrolling, which is not as comfortable as just mouse scrolling.

About the themes: I don't think this is a big issue, since you can choose the colors by yourself (or just keep the default/no color).

@h0jeZvgoxFepBQ2C
Copy link
Author

Is there any feedback to this? Would you accept a PR (not sure if I'm experienced enough to do so)?

@JaspalSuri
Copy link

I will pass this along to the dev team and someone will get back to you sometime next week (if not sooner). :)

@moughxyz
Copy link
Member

We're not currently undertaking new features on editors until we complete our client applications major 3.5 release.

@h0jeZvgoxFepBQ2C
Copy link
Author

Is there any estimate when 3.5 will arrive?

@JaspalSuri
Copy link

Currently no ETA on when it will arrive, but you can track some of the dev team's progress here.

@h0jeZvgoxFepBQ2C
Copy link
Author

So are there any plans for this feature now, since 3.5 is out?

Btw: I helped myself (a bit) by just adding emojis to the tokens which I want to hover 🌊🌊🌊🛳🌊🌊🏖🌴..
But setting a background color would help much more to find the entries fast.

@JaspalSuri
Copy link

Btw: I helped myself (a bit) by just adding emojis to the tokens which I want to hover 🌊🌊🌊🛳🌊🌊🏖🌴..

That's great to hear!

So are there any plans for this feature now, since 3.5 is out?

I've added it to our todo list, so it's just a matter of time until we get to revisiting the tasks pertaining to the TokenVault editor. The resulting changes might not be similar what you initially had in mind, but we'll consider what will ultimately be the best way to make each entry distinguishable (while keeping the editor maintainable).

@h0jeZvgoxFepBQ2C
Copy link
Author

Since #49 is merged, I'm closing this issue. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants