Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lit-GPT follow up #1863

Closed
4 tasks
aniketmaurya opened this issue Sep 26, 2023 · 3 comments
Closed
4 tasks

Lit-GPT follow up #1863

aniketmaurya opened this issue Sep 26, 2023 · 3 comments

Comments

@aniketmaurya
Copy link
Contributor

@brianwgoldman
Copy link
Contributor

Not sure if this already covered, but it appears LitGPTTokenizer._tokenize_do_it also needs to be updated in order to report a 'tokens' key in the dictionary. Specifically, CachingTokenizer calls that method here and the in the next call expects the response dictionary to have an 'tokens' key here

As an alternative, it looks like LitGPTTokenizer could override _tokenization_raw_response_to_tokens.

@yifanmai
Copy link
Collaborator

yifanmai commented Nov 7, 2023

cc @JosselinSomervilleRoberts for recent changes to LitGPTTokenizer

@yifanmai
Copy link
Collaborator

yifanmai commented Aug 5, 2024

Closing this because we should migrate to use the new LitGPT API, and also the new HELM model_deployments.yaml format. See #1783 for details.

@yifanmai yifanmai closed this as not planned Won't fix, can't repro, duplicate, stale Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants