-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON serialization performance #133
Comments
Good to know. I kind of doubt it'll matter here? I only use it for metadata for the caches. The metadata is like 500B per chunk, 3-10K per cache, and roughly a similar amount per shard. Even with Python as slow as it is, I'd hope this isn't a big deal? |
Yeah actually I think we can ignore this because it's not on the performance critical path. I got confused as to where JSON is used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dataclasses_json could be a performance bottleneck. dataclasses_json is reflection-based (like Dacite), which is an order of magnitude slower than codegen-based approaches (like cattrs).
See:
The text was updated successfully, but these errors were encountered: