Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on Confidence Interval #5

Open
xchani opened this issue Jul 20, 2022 · 4 comments
Open

Question on Confidence Interval #5

xchani opened this issue Jul 20, 2022 · 4 comments

Comments

@xchani
Copy link

xchani commented Jul 20, 2022

The calculation of the confidence interval as shown in the following line is $\mu \pm \frac{\sigma}{\sqrt{s}}\sqrt{2\log{\frac{1}{2\delta}}}$, which does not align with the formula in the paper. Is that because it's a one-sided confidence interval?

https://github.com/stanford-futuredata/supg/blob/master/supg/sampler/imp_sampler.py#L101

@ddkang
Copy link
Contributor

ddkang commented Jul 20, 2022

I believe the exact delta that goes in changes depending on the sampler. The SamplingBounds class simply accepts a user-provided delta, e.g., here: https://github.com/stanford-futuredata/supg/blob/master/supg/selector/recall_selector.py#L98

@xchani
Copy link
Author

xchani commented Jul 20, 2022

Thanks for the prompt reply. I also noticed that, which leads to $\mu \pm \frac{\sigma}{\sqrt{s}}\sqrt{2\log{\frac{1}{\delta}}}$. But as specified in the Algorithm 2 of SUPG, it should be $\mu \pm \frac{\sigma}{\sqrt{s}}\sqrt{2\log{\frac{1}{\frac{1}{2} \delta}}}$, right?

@ddkang
Copy link
Contributor

ddkang commented Jul 20, 2022

Hmm, I will need to look into this, but I think your initial comment might be correct. We only need a one-sided interval for each bound.

@xchani
Copy link
Author

xchani commented Jul 20, 2022

Thanks. Please let me know once you figure it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants