Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel augmentation is incompatible with sqlite #849

Open
gcampax opened this issue Dec 6, 2021 · 1 comment
Open

Parallel augmentation is incompatible with sqlite #849

gcampax opened this issue Dec 6, 2021 · 1 comment

Comments

@gcampax
Copy link
Contributor

gcampax commented Dec 6, 2021

SQLite doesn't like being called from workers, apparently.
It dies with an error of the form:

FATAL ERROR: Error::ThrowAsJavaScriptException napi_throw
 1: 0xa24ed0 node::Abort() [node]
 2: 0x966115 node::FatalError(char const*, char const*) [node]
 3: 0x96611e  [node]
 4: 0x9f764b napi_fatal_error [node]
 5: 0x7fe3a802c92d  [/var/home/gcampagn/Projects/thingpedia-common-devices/node_modules/sqlite3/lib/binding/napi-v3-linux-x64/node_sqlite3.node]
 6: 0x7fe3a802dd63 Napi::Error::ThrowAsJavaScriptException() const [/var/home/gcampagn/Projects/thingpedia-common-devices/node_modules/sqlite3/lib/binding/napi-v3-linux-x64/node_sqlite3.node]
 7: 0x7fe3a8043ec6 node_sqlite3::Statement::Statement(Napi::CallbackInfo const&) [/var/home/gcampagn/Projects/thingpedia-common-devices/node_modules/sqlite3/lib/binding/napi-v3-linux-x64/node_sqlite3.node]
 8: 0x7fe3a8051ed3 Napi::ObjectWrap<node_sqlite3::Statement>::ConstructorCallbackWrapper(napi_env__*, napi_callback_info__*)::{lambda()#1}::operator()() const [/var/home/gcampagn/Projects/thingpedia-common-devices/node_modules/sqlite3/lib/binding/napi-v3-linux-x64/node_sqlite3.node]
 9: 0x7fe3a8051236 Napi::ObjectWrap<node_sqlite3::Statement>::ConstructorCallbackWrapper(napi_env__*, napi_callback_info__*) [/var/home/gcampagn/Projects/thingpedia-common-devices/node_modules/sqlite3/lib/binding/napi-v3-linux-x64/node_sqlite3.node]
10: 0x9da63f  [node]
11: 0xc07ac5  [node]
12: 0xc080cf  [node]
13: 0xc086f6 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [node]
14: 0x1427159  [node]

This means that parallel augmentation does not work, and using SQLite doesn't actually fix #778

@gcampax
Copy link
Contributor Author

gcampax commented Dec 6, 2021

Underlying issue: TryGhost/node-sqlite3#1381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant