Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DialogueHistoryResultItem.clone is not a deep-clone #364

Open
gcampax opened this issue Jul 15, 2021 · 0 comments
Open

DialogueHistoryResultItem.clone is not a deep-clone #364

gcampax opened this issue Jul 15, 2021 · 0 comments
Labels
bug P2 We need to fix it (backlog)

Comments

@gcampax
Copy link
Contributor

gcampax commented Jul 15, 2021

All Ast.Node.clone methods should be deep-clones and clone all descendant Ast nodes. DialogueHistoryResultItem instead shares the Ast Value which is a bug.
@gcampax gcampax added the bug label Jul 15, 2021
@nrser nrser added the P2 We need to fix it (backlog) label Aug 4, 2021
@gcampax gcampax mentioned this issue Aug 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug P2 We need to fix it (backlog)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nrser @gcampax