This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(prototypes): banner alerts with different intents #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1083 +/- ##
==========================================
+ Coverage 82.16% 82.17% +<.01%
==========================================
Files 701 701
Lines 8597 8596 -1
Branches 1251 1178 -73
==========================================
Hits 7064 7064
+ Misses 1517 1516 -1
Partials 16 16
Continue to review full report at Codecov.
|
|
There is an autoclose bug:
UPD: nevermind, my branch was outdated... |
bmdalex
force-pushed
the
proto/banner-alerts
branch
2 times, most recently
from
34c2167
to
c090a73
Compare
mnajdova
reviewed
Mar 21, 2019
packages/react/src/themes/teams/components/Alert/alertStyles.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Mar 21, 2019
bmdalex
force-pushed
the
proto/banner-alerts
branch
from
ba59df5
to
4570109
Compare
layershifter
approved these changes
Mar 22, 2019
bmdalex
force-pushed
the
proto/banner-alerts
branch
from
8864362
to
647d443
Compare
bmdalex
force-pushed
the
proto/banner-alerts
branch
from
647d443
to
8114d4c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(prototypes): banner alerts with different intents
Description:
This PR contains:
docs/src/prototypes/alerts/AnimatedBannerAlert.tsx:BannerAlert, a customized prototype usingAlertcomponent that can express different intents through boolean propsdocs/src/prototypes/alerts/BannerAlerts.tsx: a view showing anAnimatedBannerAlertcustom component on top of a compose boxDemo: