-
Notifications
You must be signed in to change notification settings - Fork 55
feat(Icon): Add and export missing icons to Teams Theme #1390
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1390 +/- ##
==========================================
+ Coverage 73.45% 73.49% +0.03%
==========================================
Files 778 786 +8
Lines 5859 5867 +8
Branches 1706 1706
==========================================
+ Hits 4304 4312 +8
Misses 1549 1549
Partials 6 6
Continue to review full report at Codecov.
|
CHANGELOG.md
Outdated
@@ -26,6 +26,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
- Add `expanded` prop to `Accordion` @silviuavram ([#1322](https://github.com/stardust-ui/react/pull/1322)) | |||
- Replace `react-popper` package with custom `Popper` component and exposed as `UNSTABLE_Popper` positioning helper @Bugaa92 ([#1358](https://github.com/stardust-ui/react/pull/1358)) | |||
- Add strict types for the `colorScheme` props used in the components' `variables` @mnajdova([#1340](https://github.com/stardust-ui/react/pull/1340)) | |||
- Add and Export message-seen, presence-available, presence-stroke and open-outside icons in Teams Theme @joheredi ([#1390](https://github.com/stardust-ui/react/pull/1390)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please mention the eye-friendlier icon as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, thanks!
@codepretty, could you, please, check the names for exported icons?
|
a lot of the names are too context specific. would suggest renaming to something more descriptive of what the icon looks like or more generic cases. |
Adding and exporting the following icons
The 3 added icons do not contain an outline version. Spoke with @codepretty offline about this and she is requesting the outline versions from design, but suggested to add the filled version and update when the outlines are ready.