This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Icon): Add and export missing icons to Teams Theme #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joheredi
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1390 +/- ##
==========================================
+ Coverage 73.45% 73.49% +0.03%
==========================================
Files 778 786 +8
Lines 5859 5867 +8
Branches 1706 1706
==========================================
+ Hits 4304 4312 +8
Misses 1549 1549
Partials 6 6
Continue to review full report at Codecov.
|
mnajdova
reviewed
May 27, 2019
CHANGELOG.md
Outdated
| @@ -26,6 +26,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
| - Add `expanded` prop to `Accordion` @silviuavram ([#1322](https://github.com/stardust-ui/react/pull/1322)) | |||
| - Replace `react-popper` package with custom `Popper` component and exposed as `UNSTABLE_Popper` positioning helper @Bugaa92 ([#1358](https://github.com/stardust-ui/react/pull/1358)) | |||
| - Add strict types for the `colorScheme` props used in the components' `variables` @mnajdova([#1340](https://github.com/stardust-ui/react/pull/1340)) | |||
| - Add and Export message-seen, presence-available, presence-stroke and open-outside icons in Teams Theme @joheredi ([#1390](https://github.com/stardust-ui/react/pull/1390)) | |||
There was a problem hiding this comment.
Please mention the eye-friendlier icon as well.
mnajdova
approved these changes
May 27, 2019
|
@codepretty, could you, please, check the names for exported icons?
|
|
a lot of the names are too context specific. would suggest renaming to something more descriptive of what the icon looks like or more generic cases. |
This was referenced Mar 11, 2020
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding and exporting the following icons
The 3 added icons do not contain an outline version. Spoke with @codepretty offline about this and she is requesting the outline versions from design, but suggested to add the filled version and update when the outlines are ready.