-
Notifications
You must be signed in to change notification settings - Fork 55
feat(Icon): Icons for screen sharing control in the calling screen #1490
feat(Icon): Icons for screen sharing control in the calling screen #1490
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1490 +/- ##
==========================================
+ Coverage 73.44% 73.45% +0.01%
==========================================
Files 818 822 +4
Lines 6179 6183 +4
Branches 1793 1793
==========================================
+ Hits 4538 4542 +4
Misses 1636 1636
Partials 5 5
Continue to review full report at Codecov.
|
...ges/react/src/themes/teams/components/Icon/svg/ProcessedIcons/icons-call-control-request.tsx
Show resolved
Hide resolved
…jaya/screensharing-control-viewer-icons
@codepretty, could you, please, take a look and verify SVG paths/viewport size/name for the introduced icon? Thank you! |
@@ -150,6 +152,8 @@ export default { | |||
'call-parking': callParking, | |||
'call-video': callVideo, | |||
'call-video-off': callVideoOff, | |||
'call-control-release': callControlRelease, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets ensure those are pasted in alphabetical order to the set of other ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed to keep 'concepts-based' order
@@ -12,6 +12,8 @@ import bullets from './bullets' | |||
import calendar from './calendar' | |||
import call from './call' | |||
import callParking from './callParking' | |||
import callControlRelease from './callControlRelease' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets maintain alphabetical order, to simplify search scenarios
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am keeping release and request as a group (viewer) as they are most closely related. The other call-control-xxx icons are a different group (sender)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have grouped them by concepts as opposed to lexical order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing list is already out of order. Do you want me to fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, lets stick to the order pattern already established - thank you for clarification!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, just add changelog entry
Problem description
Please port the new ubar icons for screen sharing control to StarDust